style(lint): enable clippy::single_match_else#175
Open
tupe12334 wants to merge 1 commit into
Open
Conversation
Promote clippy::single_match_else to deny (incremental ratchet). The one violation was in run_clean: a match on find_repo_root_from with a trivial Some arm and an early-returning None arm. Rewrite as an idiomatic let-else, which reads as the guard it is. cargo clippy --all-targets and cargo test both pass. Closes #158 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promotes
clippy::single_match_elsetodeny(the repo's incremental lint ratchet) and fixes the single existing violation.Why
In
run_clean(src/bin/main.rs),find_repo_root_fromwas destructured with amatchwhoseSomearm was trivial and whoseNonearm returned early. That's exactly the shapesingle_match_elseflags. Rewritten as an idiomaticlet ... else, which reads as the guard it is:Checks
cargo clippy --all-targets— cleancargo test— 15 passedcargo fmt --check— cleanCloses #158
This pull request was opened by the Open issues → fix PRs (owned repos + my orgs) routine of moadim.